Change default max-transaction-time #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SEGFAULT and deadlock.
greg7mdp
reviewed
Sep 19, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…eship comparison.
… of three_queue_executor. Simplifies logic fixes issues with previous approach. Also add some poll() calls to make sure queues have latest tasks to execute.
greg7mdp
approved these changes
Sep 21, 2023
linh2931
reviewed
Sep 22, 2023
libraries/custom_appbase/include/eosio/chain/exec_pri_queue.hpp
Outdated
Show resolved
Hide resolved
| // as tasks will never execute. User is responsible for not queueing | ||
| // read_exclusive tasks if no read-only thread pool is available. | ||
| }; | ||
|
|
There was a problem hiding this comment.
You can show an example of what read_only queue and read_exclusive queue store.
There was a problem hiding this comment.
You mean add a comment that says that read_exclusive is currently only for read-only trx processing?
linh2931
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max-transaction-timechanged from 30ms to 499ms.max-transaction-timeconfig setting and use the default. Settingmax-transaction-timevalue to be greater than the on-chain consensus valuemax_transaction_cpu_usagemeans the on-chain value is the limiting factor. This allows the value to be set universally for all nodes by changing the on-chain consensus value ofmax_transaction_cpu_usage. Currently this is set to 150ms on EOS Mainnet. https://bloks.io/account/eosio?loadContract=true&tab=Tables&account=eosio&scope=eosio&limit=100&table=globalread-only-threadsoption.max-transaction-time, read-only transactions are effectively limited byread-only-read-window-time-usbecause it is less thanmax-transaction-time. Since, long-running read-only transactions are desired, they have been moved to run exclusively on read-only threads. A node that is not configured withread-only-threadsgreater than0will immediately fail any read-only transactions with errorunsupported_feature: read-only transactions execution not enabled on API node. Set read-only-threads > 0.producer_pluginshutdown which properly stops the read-only thread-pool. This fix should be back-ported to4.0.x.Resolves #1639